Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade storybook and set to fixed minor version 8.4 #3640

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

jawinn
Copy link
Collaborator

@jawinn jawinn commented Mar 21, 2025

Description

fix: downgrade storybook and set to fixed minor version 8.4

Temporarily downgrade storybook to the previously working 8.4.7, to fix issues occuring in 8.5 and 8.6 that cause all docs descriptions to be missing.

Also removes the StoryStoreV7 option deprecated in 8.0 that was pointed out by the storybook upgrader during testing.

CSS-1138

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Storybook docs descriptions are appearing
  • Running Storybook version is 8.4.7

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

Temporarily downgrade storybook to the previously working 8.4.7,
to fix issues occuring in 8.5 and 8.6 that cause all docs
descriptions to be missing.
Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 131dd97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 21, 2025

File metrics

Summary

Total size: 1.37 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Mar 21, 2025

🚀 Deployed on https://pr-3640--spectrum-css.netlify.app

@jawinn jawinn marked this pull request as ready for review March 25, 2025 16:02
Remove old option flagged during Storybook upgrade:
"StoryStoreV7 feature must be removed from your Storybook
configuration. This feature was removed in Storybook 8.0.0."
Copy link
Member

@cdransf cdransf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — nice to have the descriptions back. ✨

@castastrophe castastrophe merged commit 68b85ca into spectrum-two Mar 27, 2025
19 of 24 checks passed
@castastrophe castastrophe deleted the jawinn/fix-s2-storybook-downgrade branch March 27, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants